feat: drop msvc emulation mode #1004
Conversation
|
An automated preview of the documentation is available at https://1004.mrdocs.prtest2.cppalliance.org/index.html |
|
@alandefreitas please advice on how to test this (so that we are informed when the tools stops working on Windows) |
|
An automated preview of the documentation is available at https://1004.mrdocs.prtest2.cppalliance.org/index.html |
3 similar comments
|
An automated preview of the documentation is available at https://1004.mrdocs.prtest2.cppalliance.org/index.html |
|
An automated preview of the documentation is available at https://1004.mrdocs.prtest2.cppalliance.org/index.html |
|
An automated preview of the documentation is available at https://1004.mrdocs.prtest2.cppalliance.org/index.html |
K-ballo
force-pushed
the
drop-msvc-emulation
branch
from
6d43aed to
92ae4ff
Compare
|
An automated preview of the documentation is available at https://1004.mrdocs.prtest2.cppalliance.org/index.html |
K-ballo
force-pushed
the
drop-msvc-emulation
branch
from
92ae4ff to
57011a5
Compare
|
An automated preview of the documentation is available at https://1004.mrdocs.prtest2.cppalliance.org/index.html |
|
An automated preview of the documentation is available at https://1004.mrdocs.prtest2.cppalliance.org/index.html |
|
This will be squashed I hope? |
There was a problem hiding this comment.
Pull Request Overview
This PR removes MSVC emulation mode from the MrDocs compilation database handling, simplifying command line processing by always using Clang's native format instead of supporting both Clang and MSVC/clang-cl command line styles.
- Removes driver mode detection and conditional command line formatting
- Adds explicit translation of clang-cl
/std:flags to Clang-std=format - Updates option filtering to exclude more MSVC-specific flags
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/lib/MrDocsCompilationDatabase.cpp | Core changes removing MSVC emulation and adding clang-cl flag translation |
| src/test/lib/MrDocsCompilationDatabase.cpp | New test file validating clang-cl flag translation functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
An automated preview of the documentation is available at https://1004.mrdocs.prtest2.cppalliance.org/index.html |
|
An automated preview of the documentation is available at https://1004.mrdocs.prtest2.cppalliance.org/index.html |
as discussed in #997